e65c1df229
Spec: specs/dot_alfred_v2.md (Phase 2).
New package alfred/infrastructure/persistence/dot_alfred/v2/:
* sidecar_release.py / sidecar_root.py — Pydantic DTOs
(extra="forbid", frozen=True) for per-item sidecars and the
library-root index. schema_version enforced via model_validator.
* serializer.py — read_yaml / atomic_write_yaml (.tmp + os.replace).
SidecarSchemaError wraps YAML + Pydantic errors uniformly.
* bridge.py — lossless domain <-> sidecar for SeriesRelease /
MovieRelease; projection-only show_index_entry_from /
movie_index_entry_from with multi-episode-file flattening.
* repository.py — DotAlfredSeriesReleaseRepository /
DotAlfredMovieReleaseRepository (log+skip on corruption),
DotAlfredTVShowLibraryIndex / DotAlfredMovieLibraryIndex with
silent auto-heal on missing/corrupt index reads. Writes never
auto-heal (read paths handle that).
TMDB client extensions:
* TmdbSeasonInfo / TmdbShowInfo DTOs + pure parse_tv_show_info.
* TMDBClient.get_tv_show_info aggregates /tv/{id} +
/tv/{id}/external_ids.
Domain change:
* SubtitleTrack gains is_sdh: bool = False, populated from
ffprobe's hearing_impaired disposition. Required for v2 sidecar
parity (spec replaces v1's type: "sdh" with explicit flag).
Default keeps every existing caller unchanged.
Tests: 37 new v2 integration tests on tmp_path (round-trips, atomic
writes, schema mismatch handling, anchor warnings, auto-heal paths)
plus 16 TMDB DTO tests. Full suite: 1240 -> 1277 passed.
Implementation notes filed in .claude/specs/dot_alfred_v2_notes.md
(strict=True trade-off, upsert signature deviation from spec, etc.).
Phases 3-5 (TVShow/Movie refactor to TMDB-only, rescan_show rewrite,
v1 deletion + wiring) are next.
169 lines
5.2 KiB
Python
169 lines
5.2 KiB
Python
"""Tests for the pure parsing helpers in ``alfred.infrastructure.api.tmdb.dto``.
|
|
|
|
These tests exercise :func:`parse_tv_show_info` without any HTTP — the
|
|
function takes the raw dicts that the client would otherwise pass after
|
|
deserializing the TMDB JSON response. The reference date is injected so
|
|
the ``aired`` derivation is deterministic.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import date
|
|
|
|
import pytest
|
|
|
|
from alfred.infrastructure.api.tmdb.dto import (
|
|
TmdbSeasonInfo,
|
|
TmdbShowInfo,
|
|
parse_tv_show_info,
|
|
)
|
|
|
|
REF_DATE = date(2026, 5, 25)
|
|
|
|
|
|
def _details(**overrides):
|
|
base = {
|
|
"id": 84958,
|
|
"name": "Foundation",
|
|
"status": "Returning Series",
|
|
"seasons": [],
|
|
}
|
|
base.update(overrides)
|
|
return base
|
|
|
|
|
|
class TestParseTvShowInfoHappyPath:
|
|
def test_minimal(self):
|
|
info = parse_tv_show_info(
|
|
_details(),
|
|
{"imdb_id": "tt0804484"},
|
|
today=REF_DATE,
|
|
)
|
|
assert info == TmdbShowInfo(
|
|
tmdb_id=84958,
|
|
imdb_id="tt0804484",
|
|
name="Foundation",
|
|
status="Returning Series",
|
|
seasons=(),
|
|
)
|
|
|
|
def test_with_seasons(self):
|
|
info = parse_tv_show_info(
|
|
_details(
|
|
seasons=[
|
|
{"season_number": 1, "episode_count": 10, "air_date": "2021-09-24"},
|
|
{"season_number": 2, "episode_count": 10, "air_date": "2023-07-14"},
|
|
{"season_number": 3, "episode_count": 10, "air_date": "2027-01-01"},
|
|
],
|
|
),
|
|
{"imdb_id": "tt0804484"},
|
|
today=REF_DATE,
|
|
)
|
|
assert info.seasons == (
|
|
TmdbSeasonInfo(number=1, episode_count=10, aired=True),
|
|
TmdbSeasonInfo(number=2, episode_count=10, aired=True),
|
|
TmdbSeasonInfo(number=3, episode_count=10, aired=False),
|
|
)
|
|
|
|
|
|
class TestParseTvShowInfoImdb:
|
|
def test_missing_imdb_id_becomes_none(self):
|
|
info = parse_tv_show_info(_details(), {}, today=REF_DATE)
|
|
assert info.imdb_id is None
|
|
|
|
def test_null_imdb_id_becomes_none(self):
|
|
info = parse_tv_show_info(_details(), {"imdb_id": None}, today=REF_DATE)
|
|
assert info.imdb_id is None
|
|
|
|
def test_empty_string_imdb_id_becomes_none(self):
|
|
info = parse_tv_show_info(_details(), {"imdb_id": ""}, today=REF_DATE)
|
|
assert info.imdb_id is None
|
|
|
|
|
|
class TestParseTvShowInfoAired:
|
|
def test_air_date_today_counts_as_aired(self):
|
|
info = parse_tv_show_info(
|
|
_details(
|
|
seasons=[{"season_number": 1, "episode_count": 1, "air_date": "2026-05-25"}],
|
|
),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|
|
assert info.seasons[0].aired is True
|
|
|
|
def test_air_date_tomorrow_not_aired(self):
|
|
info = parse_tv_show_info(
|
|
_details(
|
|
seasons=[{"season_number": 1, "episode_count": 1, "air_date": "2026-05-26"}],
|
|
),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|
|
assert info.seasons[0].aired is False
|
|
|
|
def test_no_air_date_not_aired(self):
|
|
info = parse_tv_show_info(
|
|
_details(
|
|
seasons=[{"season_number": 1, "episode_count": 1}],
|
|
),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|
|
assert info.seasons[0].aired is False
|
|
|
|
def test_empty_air_date_not_aired(self):
|
|
info = parse_tv_show_info(
|
|
_details(
|
|
seasons=[{"season_number": 1, "episode_count": 1, "air_date": ""}],
|
|
),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|
|
assert info.seasons[0].aired is False
|
|
|
|
def test_malformed_air_date_not_aired(self):
|
|
info = parse_tv_show_info(
|
|
_details(
|
|
seasons=[{"season_number": 1, "episode_count": 1, "air_date": "soon"}],
|
|
),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|
|
assert info.seasons[0].aired is False
|
|
|
|
|
|
class TestParseTvShowInfoErrors:
|
|
def test_missing_id_raises(self):
|
|
with pytest.raises(ValueError, match="'id'"):
|
|
parse_tv_show_info({"name": "X", "status": "Ended"}, {}, today=REF_DATE)
|
|
|
|
def test_missing_name_raises(self):
|
|
with pytest.raises(ValueError, match="'name'"):
|
|
parse_tv_show_info({"id": 1, "status": "Ended"}, {}, today=REF_DATE)
|
|
|
|
def test_empty_name_raises(self):
|
|
with pytest.raises(ValueError, match="'name'"):
|
|
parse_tv_show_info(
|
|
{"id": 1, "name": "", "status": "Ended"}, {}, today=REF_DATE
|
|
)
|
|
|
|
def test_missing_status_raises(self):
|
|
with pytest.raises(ValueError, match="'status'"):
|
|
parse_tv_show_info({"id": 1, "name": "X"}, {}, today=REF_DATE)
|
|
|
|
def test_season_missing_number_raises(self):
|
|
with pytest.raises(ValueError, match="season_number"):
|
|
parse_tv_show_info(
|
|
_details(seasons=[{"episode_count": 5}]),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|
|
|
|
def test_season_missing_episode_count_raises(self):
|
|
with pytest.raises(ValueError, match="episode_count"):
|
|
parse_tv_show_info(
|
|
_details(seasons=[{"season_number": 1}]),
|
|
{},
|
|
today=REF_DATE,
|
|
)
|