francwa
e6ee700825
Domain services no longer call subprocess or pathlib directly. Introduces two Protocol ports in domain/shared/ports/: MediaProber.list_subtitle_streams(video) -> list[SubtitleStreamInfo] FilesystemScanner.scan_dir / stat / read_text -> list[FileEntry] | ... Concrete adapters live in infrastructure/: FfprobeMediaProber (wraps subprocess + ffprobe + JSON) PathlibFilesystemScanner (wraps pathlib + os reads) SubtitleIdentifier and PatternDetector now take (kb, prober, scanner) at construction time. Their internals work over FileEntry snapshots and SubtitleStreamInfo records — no more ad-hoc Path.is_file/iterdir/stat or embedded subprocess.run loops. _count_entries now takes raw SRT text (returned by scanner.read_text) so SRT-only entry counting stays out of the FS layer. manage_subtitles use case instantiates the two adapters once and injects them into both services. Tests pass real adapters and patch `alfred.infrastructure.probe.ffprobe_prober.subprocess.run` for the ffprobe-failure cases. _classify_single tests build FileEntry via a small helper. Domain is now free of subprocess / direct filesystem reads in the subtitle pipeline. The only remaining I/O hooks are FilePath VO convenience methods (exists/is_file/is_dir) which stay as a deliberate affordance on the value object.
18 lines
547 B
Python
18 lines
547 B
Python
"""Ports — Protocol interfaces the domain depends on.
|
|
|
|
Adapters live in ``alfred/infrastructure/`` and implement these protocols.
|
|
Domain code never imports infrastructure; it accepts a port via constructor
|
|
injection and calls it. Tests can pass in-memory fakes that satisfy the
|
|
Protocol without going through real I/O.
|
|
"""
|
|
|
|
from .filesystem_scanner import FileEntry, FilesystemScanner
|
|
from .media_prober import MediaProber, SubtitleStreamInfo
|
|
|
|
__all__ = [
|
|
"FileEntry",
|
|
"FilesystemScanner",
|
|
"MediaProber",
|
|
"SubtitleStreamInfo",
|
|
]
|