feat: split resolve_destination, persona-driven prompts, qBittorrent relocation
Destination resolution
- Replace the single ResolveDestinationUseCase with four dedicated
functions, one per release type:
resolve_season_destination (pack season, folder move)
resolve_episode_destination (single episode, file move)
resolve_movie_destination (movie, file move)
resolve_series_destination (multi-season pack, folder move)
- Each returns a dedicated DTO carrying only the fields relevant to
that release type — no more polymorphic ResolvedDestination with
half the fields unused depending on the case.
- Looser series folder matching: exact computed-name match is reused
silently; any deviation (different group, multiple candidates) now
prompts the user with all options including the computed name.
Agent tools
- Four new tools wrapping the use cases above; old resolve_destination
removed from the registry.
- New move_to_destination tool: create_folder + move, chained — used
after a resolve_* call to perform the actual relocation.
- Low-level filesystem_operations module (create_folder, move via mv)
for instant same-FS renames (ZFS).
Prompt & persona
- New PromptBuilder (alfred/agent/prompt.py) replacing prompts.py:
identity + personality block, situational expressions, memory
schema, episodic/STM/config context, tool catalogue.
- Per-user expression system: knowledge/users/common.yaml +
{username}.yaml are merged at runtime; one phrase per situation
(greeting/success/error/...) is sampled into the system prompt.
qBittorrent integration
- Credentials now come from settings (qbittorrent_url/username/password)
instead of hardcoded defaults.
- New client methods: find_by_name, set_location, recheck — the trio
needed to update a torrent's save path and re-verify after a move.
- Host→container path translation settings (qbittorrent_host_path /
qbittorrent_container_path) for docker-mounted setups.
Subtitles
- Identifier: strip parenthesized qualifiers (simplified, brazil…) at
tokenization; new _tokenize_suffix used for the episode_subfolder
pattern so episode-stem tokens no longer pollute language detection.
- Placer: extract _build_dest_name so it can be reused by the new
dry_run path in ManageSubtitlesUseCase.
- Knowledge: add yue, ell, ind, msa, rus, vie, heb, tam, tel, tha,
hin, ukr; add 'fre' to fra; add 'simplified'/'traditional' to zho.
Misc
- LTM workspace: add 'trash' folder slot.
- Default LLM provider switched to deepseek.
- testing/debug_release.py: CLI to parse a release, hit TMDB, and
dry-run the destination resolution end-to-end.
This commit is contained in:
@@ -4,15 +4,14 @@ Tests for alfred.agent.workflows.loader.WorkflowLoader
|
||||
|
||||
import pytest
|
||||
import yaml
|
||||
from pathlib import Path
|
||||
|
||||
from alfred.agent.workflows.loader import WorkflowLoader
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Fixtures
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def workflows_dir(tmp_path):
|
||||
"""A temp directory pre-populated with one valid workflow YAML."""
|
||||
@@ -32,6 +31,7 @@ def workflows_dir(tmp_path):
|
||||
def loader_from_dir(workflows_dir, monkeypatch):
|
||||
"""WorkflowLoader pointed at our temp dir."""
|
||||
import alfred.agent.workflows.loader as loader_module
|
||||
|
||||
monkeypatch.setattr(loader_module, "_WORKFLOWS_DIR", workflows_dir)
|
||||
return WorkflowLoader()
|
||||
|
||||
@@ -40,8 +40,8 @@ def loader_from_dir(workflows_dir, monkeypatch):
|
||||
# Real loader (loads actual YAML files from the repo)
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
class TestRealWorkflows:
|
||||
|
||||
class TestRealWorkflows:
|
||||
def test_organize_media_loaded(self):
|
||||
loader = WorkflowLoader()
|
||||
assert "organize_media" in loader.names()
|
||||
@@ -96,8 +96,8 @@ class TestRealWorkflows:
|
||||
# WorkflowLoader mechanics (via monkeypatched dir)
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
class TestLoaderMechanics:
|
||||
|
||||
class TestLoaderMechanics:
|
||||
def test_get_returns_workflow(self, loader_from_dir):
|
||||
wf = loader_from_dir.get("test_workflow")
|
||||
assert wf is not None
|
||||
@@ -119,6 +119,7 @@ class TestLoaderMechanics:
|
||||
def test_uses_yaml_name_field(self, tmp_path, monkeypatch):
|
||||
"""name from YAML content takes priority over filename stem."""
|
||||
import alfred.agent.workflows.loader as loader_module
|
||||
|
||||
monkeypatch.setattr(loader_module, "_WORKFLOWS_DIR", tmp_path)
|
||||
|
||||
wf = {"name": "my_custom_name", "steps": []}
|
||||
@@ -130,6 +131,7 @@ class TestLoaderMechanics:
|
||||
|
||||
def test_falls_back_to_stem_when_no_name(self, tmp_path, monkeypatch):
|
||||
import alfred.agent.workflows.loader as loader_module
|
||||
|
||||
monkeypatch.setattr(loader_module, "_WORKFLOWS_DIR", tmp_path)
|
||||
|
||||
(tmp_path / "my_workflow.yaml").write_text(yaml.dump({"steps": []}))
|
||||
@@ -138,6 +140,7 @@ class TestLoaderMechanics:
|
||||
|
||||
def test_skips_malformed_yaml(self, tmp_path, monkeypatch):
|
||||
import alfred.agent.workflows.loader as loader_module
|
||||
|
||||
monkeypatch.setattr(loader_module, "_WORKFLOWS_DIR", tmp_path)
|
||||
|
||||
(tmp_path / "valid.yaml").write_text(yaml.dump({"name": "valid", "steps": []}))
|
||||
@@ -150,10 +153,15 @@ class TestLoaderMechanics:
|
||||
def test_deterministic_load_order(self, tmp_path, monkeypatch):
|
||||
"""Files loaded in sorted order — later file wins on name collision."""
|
||||
import alfred.agent.workflows.loader as loader_module
|
||||
|
||||
monkeypatch.setattr(loader_module, "_WORKFLOWS_DIR", tmp_path)
|
||||
|
||||
(tmp_path / "a_workflow.yaml").write_text(yaml.dump({"name": "duplicate", "version": 1}))
|
||||
(tmp_path / "b_workflow.yaml").write_text(yaml.dump({"name": "duplicate", "version": 2}))
|
||||
(tmp_path / "a_workflow.yaml").write_text(
|
||||
yaml.dump({"name": "duplicate", "version": 1})
|
||||
)
|
||||
(tmp_path / "b_workflow.yaml").write_text(
|
||||
yaml.dump({"name": "duplicate", "version": 2})
|
||||
)
|
||||
|
||||
loader = WorkflowLoader()
|
||||
# b_workflow loaded last → version 2 wins
|
||||
@@ -161,6 +169,7 @@ class TestLoaderMechanics:
|
||||
|
||||
def test_empty_directory(self, tmp_path, monkeypatch):
|
||||
import alfred.agent.workflows.loader as loader_module
|
||||
|
||||
monkeypatch.setattr(loader_module, "_WORKFLOWS_DIR", tmp_path)
|
||||
|
||||
loader = WorkflowLoader()
|
||||
|
||||
Reference in New Issue
Block a user