chore: sprint cleanup — language unification, parser unification, fossils removal
Several weeks of work accumulated without being committed. Grouped here for clarity; see CHANGELOG.md [Unreleased] for the user-facing summary. Highlights ---------- P1 #2 — ISO 639-2/B canonical migration - New Language VO + LanguageRegistry (alfred/domain/shared/knowledge/). - iso_languages.yaml as single source of truth for language codes. - SubtitleKnowledgeBase now delegates lookup to LanguageRegistry; subtitles.yaml only declares subtitle-specific tokens (vostfr, vf, vff, …). - SubtitlePreferences default → ["fre", "eng"]; subtitle filenames written as {iso639_2b}.srt (legacy fr.srt still read via alias). - Scanner: dropped _LANG_KEYWORDS / _SDH_TOKENS / _FORCED_TOKENS / SUBTITLE_EXTENSIONS hardcoded dicts. - Fixed: 'hi' token no longer marks SDH (conflicted with Hindi alias). - Added settings.min_movie_size_bytes (was a module constant). P1 #3 — Release parser unification + data-driven tokenizer - parse_release() is now the single source of truth for release-name parsing. - alfred/knowledge/release/separators.yaml declares the token separators used by the tokenizer (., space, [, ], (, ), _). New conventions can be added without code changes. - Tokenizer now splits on any configured separator instead of name.split('.'). Releases like 'The Father (2020) [1080p] [WEBRip] [5.1] [YTS.MX]' parse via the direct path without sanitization fallback. - Site-tag extraction always runs first; well-formedness only rejects truly forbidden chars. - _parse_season_episode() extended with NxNN / NxNNxNN alt forms. - Removed dead helpers: _sanitize, _normalize. Domain cleanup - Deleted fossil services with zero production callers: alfred/domain/movies/services.py alfred/domain/tv_shows/services.py alfred/domain/subtitles/services.py (replaced by subtitles/services/ package) alfred/domain/subtitles/repositories.py - Split monolithic subtitle services into a package (identifier, matcher, placer, pattern_detector, utils) + dedicated knowledge/ package. - MediaInfo split into dedicated package (alfred/domain/shared/media/: audio, video, subtitle, info, matching). Persistence cleanup - Removed dead JSON repositories (movie/subtitle/tvshow_repository.py). Tests - Major expansion of the test suite organized to mirror the source tree. - Removed obsolete *_edge_cases test files superseded by structured tests. - Suite: 990 passed, 8 skipped. Misc - .gitignore: exclude env_backup/ and *.bak. - Adjustments across agent/llm, app.py, application/filesystem, and infrastructure/filesystem to align with the new domain layout.
This commit is contained in:
@@ -1,4 +1,20 @@
|
||||
"""Edge case tests for tool registry."""
|
||||
"""Edge-case tests for ``alfred.agent.registry``.
|
||||
|
||||
Covers unusual but legitimate signatures handled by the JSON-Schema
|
||||
extractor:
|
||||
|
||||
- ``TestToolEdgeCases`` — direct ``Tool`` dataclass construction with
|
||||
minimal and maximal field sets.
|
||||
- ``TestCreateToolFromFunctionEdgeCases`` — bare functions (no annotations,
|
||||
no docstring), functions with only ``*args``/``**kwargs``, generic
|
||||
``list``/``dict`` annotations, ``Optional`` unwrapping.
|
||||
- ``TestMakeToolsEdgeCases`` — global registry construction with the live
|
||||
``Settings`` object: every registered tool has a callable ``func``, a
|
||||
unique name, and a JSON-Schema-shaped ``parameters`` dict.
|
||||
|
||||
Uses ``memory.ltm.workspace.download`` (the current API) when staging the
|
||||
filesystem-backed tools.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
|
||||
@@ -258,7 +274,7 @@ class TestToolExecution:
|
||||
def test_tool_returns_dict(self, memory, real_folder):
|
||||
"""Should return dict from tool execution."""
|
||||
tools = make_tools(settings)
|
||||
memory.ltm.download_folder = str(real_folder["downloads"])
|
||||
memory.ltm.workspace.download = str(real_folder["downloads"])
|
||||
|
||||
result = tools["list_folder"].func(folder_type="download")
|
||||
|
||||
@@ -267,7 +283,7 @@ class TestToolExecution:
|
||||
def test_tool_returns_status(self, memory, real_folder):
|
||||
"""Should return status in result."""
|
||||
tools = make_tools(settings)
|
||||
memory.ltm.download_folder = str(real_folder["downloads"])
|
||||
memory.ltm.workspace.download = str(real_folder["downloads"])
|
||||
|
||||
result = tools["list_folder"].func(folder_type="download")
|
||||
|
||||
@@ -295,7 +311,7 @@ class TestToolExecution:
|
||||
def test_tool_handles_extra_args(self, memory, real_folder):
|
||||
"""Should handle extra arguments."""
|
||||
tools = make_tools(settings)
|
||||
memory.ltm.download_folder = str(real_folder["downloads"])
|
||||
memory.ltm.workspace.download = str(real_folder["downloads"])
|
||||
|
||||
# Extra args should raise TypeError
|
||||
with pytest.raises(TypeError):
|
||||
|
||||
Reference in New Issue
Block a user